SteNicholas commented on code in PR #8374:
URL: https://github.com/apache/hudi/pull/8374#discussion_r1156854003
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##########
@@ -195,15 +194,13 @@ public void setOperatorEventGateway(OperatorEventGateway
operatorEventGateway) {
private void restoreWriteMetadata() throws Exception {
boolean eventSent = false;
for (WriteMetadataEvent event : this.writeMetadataState.get()) {
- if (Objects.equals(this.currentInstant, event.getInstantTime())) {
- // Reset taskID for event
- event.setTaskID(taskID);
- // The checkpoint succeed but the meta does not commit,
- // re-commit the inflight instant
- this.eventGateway.sendEventToCoordinator(event);
- LOG.info("Send uncommitted write metadata event to coordinator,
task[{}].", taskID);
- eventSent = true;
- }
+ // Reset taskID for event
Review Comment:
It's better to add the test cases for recommit to verify whether the
recommit behavior could work well. The recommit behavior affects the quality of
the writen Hudi table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
