danny0405 commented on code in PR #8374:
URL: https://github.com/apache/hudi/pull/8374#discussion_r1157440398
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -203,6 +203,11 @@ public boolean isAborted(String instant) {
return this.messages.stream().anyMatch(ckpMsg ->
instant.equals(ckpMsg.getInstant()) && ckpMsg.isAborted());
}
+ @VisibleForTesting
+ public List<String> getInstantCache() {
+ return this.instantCache;
Review Comment:
This is only for test purpose, but I think you are right, this is a good
coding convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
