danny0405 commented on code in PR #8374:
URL: https://github.com/apache/hudi/pull/8374#discussion_r1156864640
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##########
@@ -195,15 +194,13 @@ public void setOperatorEventGateway(OperatorEventGateway
operatorEventGateway) {
private void restoreWriteMetadata() throws Exception {
boolean eventSent = false;
for (WriteMetadataEvent event : this.writeMetadataState.get()) {
- if (Objects.equals(this.currentInstant, event.getInstantTime())) {
- // Reset taskID for event
- event.setTaskID(taskID);
- // The checkpoint succeed but the meta does not commit,
- // re-commit the inflight instant
- this.eventGateway.sendEventToCoordinator(event);
- LOG.info("Send uncommitted write metadata event to coordinator,
task[{}].", taskID);
- eventSent = true;
- }
+ // Reset taskID for event
Review Comment:
`TestStreamWriteOperatorCoordinator#testRecommitWithPartialUncommittedEvents`
should already test this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
