xushiyan commented on code in PR #7336: URL: https://github.com/apache/hudi/pull/7336#discussion_r1236254226
########## hudi-common/src/main/java/org/apache/hudi/common/model/TaggableHoodieKey.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.model; + +import org.apache.hudi.common.util.Option; + +import javax.annotation.Nullable; + +/** + * Lean class to hold HoodieRecord information. + * This holds the HoodieKey along with the location information. + */ +public class TaggableHoodieKey extends HoodieKey { + Review Comment: i understood that you want composite pattern over inheritance - can you elaborate from the angle of disadvantages here? as in what is "incorrect from the notion". For taggable as i explained is in the context of indexing, where we have "tagLocation" and "requiresTagging" as public APIs in `HoodieIndex`, do you still feel it's confusing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
