xushiyan commented on code in PR #9058:
URL: https://github.com/apache/hudi/pull/9058#discussion_r1244012508


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -314,6 +314,12 @@ private boolean writeRecord(HoodieRecord<T> newRecord, 
Option<HoodieRecord> comb
         recordsWritten++;
       } else {
         recordsDeleted++;
+        // Clear the new location which is set for all records in init()
+        if (needsUpdateLocation()) {
+          newRecord.unseal();
+          newRecord.clearNewLocation();

Review Comment:
   by right we shouldn't let write handle know anything about index. can you 
clarify what you meant by "Flink also needs it"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to