nsivabalan commented on code in PR #9058:
URL: https://github.com/apache/hudi/pull/9058#discussion_r1244460856
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -283,6 +285,8 @@ public HoodieMetadataPayload(Option<GenericRecord>
recordOpt) {
Integer.parseInt(recordIndexRecord.get(RECORD_INDEX_FIELD_FILE_INDEX).toString()),
Long.parseLong(recordIndexRecord.get(RECORD_INDEX_FIELD_INSTANT_TIME).toString()));
}
+ } else {
+ this.isDeletedRecord = true;
Review Comment:
yes. either we should go w/ EmptyHoodieRecordPayload.
or we should add "IsDelete" flag to recordIndexMetadata similar to how we
have added it for other partitions like ColumnStatsMetadata,
BloomFilterMetadata, filesystemMetadata
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java:
##########
@@ -311,6 +311,17 @@ public void checkState() {
protected abstract T readRecordPayload(Kryo kryo, Input input);
+ /**
+ * Clears the new currentLocation of the record.
+ *
+ * This is required in the delete path so that Index can track that this
record was deleted.
+ */
+ public HoodieRecord clearNewLocation() {
Review Comment:
why return HoodieRecord. can't we return void ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
