xushiyan commented on code in PR #9058:
URL: https://github.com/apache/hudi/pull/9058#discussion_r1244188535
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -283,6 +285,8 @@ public HoodieMetadataPayload(Option<GenericRecord>
recordOpt) {
Integer.parseInt(recordIndexRecord.get(RECORD_INDEX_FIELD_FILE_INDEX).toString()),
Long.parseLong(recordIndexRecord.get(RECORD_INDEX_FIELD_INSTANT_TIME).toString()));
}
+ } else {
+ this.isDeletedRecord = true;
Review Comment:
in case of `HoodieMetadataPayload#createRecordIndexDelete`, there is
discrepancy as the payload is empty record payload. these impl. should be
aligned
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -209,9 +210,10 @@ public class HoodieMetadataPayload implements
HoodieRecordPayload<HoodieMetadata
private HoodieMetadataBloomFilter bloomFilterMetadata = null;
private HoodieMetadataColumnStats columnStatMetadata = null;
private HoodieRecordIndexInfo recordIndexMetadata;
+ private boolean isDeletedRecord = false;
public HoodieMetadataPayload(GenericRecord record, Comparable<?>
orderingVal) {
Review Comment:
to make it highlighted
```suggestion
public HoodieMetadataPayload(@Nullable GenericRecord record, Comparable<?>
orderingVal) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
