[ 
https://issues.apache.org/jira/browse/HUDI-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141754#comment-17141754
 ] 

Balaji Varadarajan commented on HUDI-1033:
------------------------------------------

[~hongdongdong] [~yanghua]: I strongly feel that we should be having only one 
test class for these. Its mostly duplicated testing otherwise and may not add 
value. I am not sure why we need to specifically test for loading the jars. 
But, it is ok to have these run only as integration tests. For that, it would 
be better to actually perform live actions (like clean/commit) instead of 
mocking. Otherwise, we can just have unit tests. 

 

> Remove redundant CLI tests 
> ---------------------------
>
>                 Key: HUDI-1033
>                 URL: https://issues.apache.org/jira/browse/HUDI-1033
>             Project: Apache Hudi
>          Issue Type: Task
>          Components: Testing
>            Reporter: Balaji Varadarajan
>            Assignee: vinoyang
>            Priority: Major
>             Fix For: 0.6.0
>
>
> There are some tests like ITTestRepairsCommand vs TestRepairsCommand, 
> ITTestCleanerCommand vs TestCleanerCommand. Please consolidate if they are 
> redundant.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to