[
https://issues.apache.org/jira/browse/HUDI-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141836#comment-17141836
]
hong dongdong commented on HUDI-1033:
-------------------------------------
[~vbalaji]: Somethings that I had not explained clearly. There is no duplicated
testing, TestXXX for unit test and ITTestXXX for integration testing, they test
different command.
For example, CleansCommand
TestCleansCommand test for commands: 'cleans show' 'clean showpartitions'.
ITTestCleansCommand test for command: 'cleans run'.
Why need integration testing? Some commands(like cleans run) run on spark, and
SparkLauncher needs to load the jars(like hudi-common/hudi-client) under
lib(generated during the package phase) when init (not means test for loading
the jars).
And, as you think, all tests actually perform live actions, not use mocking.
> Remove redundant CLI tests
> ---------------------------
>
> Key: HUDI-1033
> URL: https://issues.apache.org/jira/browse/HUDI-1033
> Project: Apache Hudi
> Issue Type: Task
> Components: Testing
> Reporter: Balaji Varadarajan
> Assignee: vinoyang
> Priority: Major
> Fix For: 0.6.0
>
>
> There are some tests like ITTestRepairsCommand vs TestRepairsCommand,
> ITTestCleanerCommand vs TestCleanerCommand. Please consolidate if they are
> redundant.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)