danny0405 commented on code in PR #9212:
URL: https://github.com/apache/hudi/pull/9212#discussion_r1264802722
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -862,11 +866,29 @@ public String startCommit(String actionType,
HoodieTableMetaClient metaClient) {
CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites());
- String instantTime = HoodieActiveTimeline.createNewInstantTime();
+ String instantTime = createCommit();
Review Comment:
Do we need this, even if there is rare oppotunity the instant time can
conflict, one of the write would fail when trying to create the instant
metadata file on the timeline, still workable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
