danny0405 commented on code in PR #9212:
URL: https://github.com/apache/hudi/pull/9212#discussion_r1266121937
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -862,11 +866,29 @@ public String startCommit(String actionType,
HoodieTableMetaClient metaClient) {
CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites());
- String instantTime = HoodieActiveTimeline.createNewInstantTime();
+ String instantTime = createCommit();
Review Comment:
> that the behavior that insert overwrite historical partition doesn't
affect the incremental writing tasks
Agree, but we also need to think through the trade-off, locking the instant
time generation is kind of costly for most of the use cases, and we might
encounter other issues because the file based lock can also time out in some
use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
