SteNicholas commented on code in PR #9212:
URL: https://github.com/apache/hudi/pull/9212#discussion_r1264842069
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -862,11 +866,29 @@ public String startCommit(String actionType,
HoodieTableMetaClient metaClient) {
CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites());
- String instantTime = HoodieActiveTimeline.createNewInstantTime();
+ String instantTime = createCommit();
Review Comment:
@danny0405, when using Spark insert overwrite historical partition and Flink
insert into current partition, the different action type of same instant have
no conflict and one of the write would fail for writing data file. We want that
the behavior that insert overwrite historical partition doesn't affect the
incremental writing tasks. Therefore we should create new and different instant
time before starting commit to avoid various cases of boundaries due to the
same instant time, for example, Spark insert overwrite historical partition and
Flink insert into current partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
