the-other-tim-brown commented on code in PR #9371:
URL: https://github.com/apache/hudi/pull/9371#discussion_r1285126721
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -146,7 +157,10 @@ protected void
setPendingInflightAndRequestedInstants(Set<String> pendingInfligh
* @param metadata commit metadata for which pre commit is being invoked.
*/
protected void preCommit(HoodieCommitMetadata metadata) {
- // To be overridden by specific engines to perform conflict resolution if
any.
+ // Create a Hoodie table after startTxn which encapsulated the commits and
files visible.
Review Comment:
I think it makes sense to leave as protected so a future implementation can
overwrite it if the want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
