the-other-tim-brown commented on code in PR #9371:
URL: https://github.com/apache/hudi/pull/9371#discussion_r1285127678
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -974,4 +1159,20 @@ public void close() {
// Stop timeline-server if running
super.close();
}
+
+ protected void updateTableMetadata(HoodieTable table, HoodieCommitMetadata
commitMetadata,
+ HoodieInstant hoodieInstant,
+ HoodieData<WriteStatus> writeStatuses) {
+ // Do not do any conflict resolution here as we do with regular writes. We
take the lock here to ensure all writes to metadata table happens within a
+ // single lock (single writer). Because more than one write to metadata
table will result in conflicts since all of them updates the same partition.
+ table.getMetadataWriter(hoodieInstant.getTimestamp())
+ .ifPresent(writer -> ((HoodieTableMetadataWriter)
writer).update(commitMetadata, writeStatuses, hoodieInstant.getTimestamp()));
+ }
+
+ protected void handleWriteErrors(List<HoodieWriteStat> writeStats,
TableServiceType tableServiceType) {
Review Comment:
Ok sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
