the-other-tim-brown commented on code in PR #9371:
URL: https://github.com/apache/hudi/pull/9371#discussion_r1285126911
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -174,11 +188,43 @@ private void inlineCompaction(HoodieTable table,
Option<Map<String, String>> ext
/**
* Ensures compaction instant is in expected state and performs Log
Compaction for the workload stored in instant-time.s
*
- * @param compactionInstantTime Compaction Instant Time
+ * @param logCompactionInstantTime Compaction Instant Time
* @return Collection of Write Status
*/
- protected HoodieWriteMetadata<O> logCompact(String compactionInstantTime,
boolean shouldComplete) {
- throw new UnsupportedOperationException("Log compaction is not supported
yet.");
+ protected HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime,
boolean shouldComplete) {
Review Comment:
this would be a breaking change in the event of someone else implementing
custom logic in a write client outside of the hudi repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
