linliu-code commented on code in PR #9593:
URL: https://github.com/apache/hudi/pull/9593#discussion_r1326453878
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -286,7 +295,15 @@ protected void writeInsertRecord(HoodieRecord<T>
newRecord) throws IOException {
if (newRecord.shouldIgnore(schema, config.getProps())) {
return;
}
Review Comment:
Good question! I just checked existing implementation of shouldIgnore:
HoodieSparkRecord return false; HoodieEmptyRecord returns false;
HoodieAvroIndexRecord returns true if the payload is sentinel, and
HoodieAvroRecord also does the similar logic. Based on these situation, we
should be able to consolidate these logic into IsValid function after we land
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
