codope commented on code in PR #9776:
URL: https://github.com/apache/hudi/pull/9776#discussion_r1348276299
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -101,12 +103,36 @@ public void addBaseFile(HoodieBaseFile dataFile) {
/**
* Add a new log file into the group.
+ *
+ * <p>CAUTION: the log file must be added in sequence of the delta commit
time.
Review Comment:
Filesystem view calls this while building filegroups and that call is in
sycnhronized block. However, we should have a multi writer and concurrent
reader test to validate. Or we can make this visible for testing and start two
threads to add log files and validate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
