danny0405 commented on code in PR #9776:
URL: https://github.com/apache/hudi/pull/9776#discussion_r1349440717
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -164,66 +163,68 @@ public HoodieAppendHandle(HoodieWriteConfig config,
String instantTime, HoodieTa
private void init(HoodieRecord record) {
if (doInit) {
- // extract some information from the first record
- SliceView rtView = hoodieTable.getSliceView();
- Option<FileSlice> fileSlice = rtView.getLatestFileSlice(partitionPath,
fileId);
- // Set the base commit time as the current instantTime for new inserts
into log files
- String baseInstantTime;
+ String prevCommit = instantTime;
String baseFile = "";
List<String> logFiles = new ArrayList<>();
- if (fileSlice.isPresent()) {
- baseInstantTime = fileSlice.get().getBaseInstantTime();
- baseFile =
fileSlice.get().getBaseFile().map(BaseFile::getFileName).orElse("");
- logFiles =
fileSlice.get().getLogFiles().map(HoodieLogFile::getFileName).collect(Collectors.toList());
- } else {
- baseInstantTime = instantTime;
- // Handle log file only case. This is necessary for the concurrent
clustering and writer case (e.g., consistent hashing bucket index).
- // NOTE: flink engine use instantTime to mark operation type, check
BaseFlinkCommitActionExecutor::execute
- if (record.getCurrentLocation() != null &&
HoodieInstantTimeGenerator.isValidInstantTime(record.getCurrentLocation().getInstantTime()))
{
- baseInstantTime = record.getCurrentLocation().getInstantTime();
+ if (config.isCDCEnabled()) {
Review Comment:
We already have it, that is `TestCDCDataFrameSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
