codope commented on code in PR #9776:
URL: https://github.com/apache/hudi/pull/9776#discussion_r1348351265
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -203,11 +221,10 @@ protected List<HoodieFileGroup>
buildFileGroups(Stream<HoodieBaseFile> baseFileS
if (baseFiles.containsKey(pair)) {
Review Comment:
`baseFiles` need to be sorted in rever order or instant (start) time as per
the algorithm mentioned in RFC. Where are we ensuring that?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -203,11 +221,10 @@ protected List<HoodieFileGroup>
buildFileGroups(Stream<HoodieBaseFile> baseFileS
if (baseFiles.containsKey(pair)) {
baseFiles.get(pair).forEach(group::addBaseFile);
}
- if (logFiles.containsKey(pair)) {
- logFiles.get(pair).forEach(group::addLogFile);
- }
-
if (addPendingCompactionFileSlice) {
+ // pending compaction file slice must be added before log files so that
+ // the log files completed later than the compaction instant time
could be included
+ // in the file slice with that compaction instant time as base instant
time.
Review Comment:
how about pending log compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
