Mathieu1124 commented on a change in pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#discussion_r464165358
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteCommitCallbackConfig.java
##########
@@ -91,13 +103,44 @@ public Builder withCallbackHttpApiKey(String apiKey) {
return this;
}
+ public Builder withCallbackKafkaBootstrapServers(String
kafkaBootstrapServers) {
Review comment:
>
>
> I am thinking one thing: the config options of the callback feature for
Kafka are left in `hudi-client`, while the implementation hosts in
`hudi-utilities`, if it's suitable.
It is truly a problem. since kafka callback implementation is placed in
hudi-utilities, the config should be there too. will move it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
