yanghua commented on a change in pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#discussion_r465708684
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -535,6 +537,11 @@ private HoodieWriteConfig
getHoodieClientConfig(SchemaProvider schemaProvider) {
}
HoodieWriteConfig config = builder.build();
+ // set default value for {@link HoodieWriteCommitKafkaCallbackConfig} if
needed.
+ if (config.writeCommitCallbackOn() &&
HoodieWriteCommitKafkaCallback.class.getName().equals(config.getCallbackClass()))
{
Review comment:
If users configure http callback? Why we only consider Kafka callback
here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
