Mathieu1124 commented on a change in pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#discussion_r465761151
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -535,6 +537,11 @@ private HoodieWriteConfig
getHoodieClientConfig(SchemaProvider schemaProvider) {
}
HoodieWriteConfig config = builder.build();
+ // set default value for {@link HoodieWriteCommitKafkaCallbackConfig} if
needed.
+ if (config.writeCommitCallbackOn() &&
HoodieWriteCommitKafkaCallback.class.getName().equals(config.getCallbackClass()))
{
Review comment:
>
>
> If users configure http callback? Why we only consider Kafka callback here?
the config of http callback will be Initialized when HoodieWriteClient set
up, while kafka's can't. the kafka's config can only be set up in
hudi-utilities module, so the logic above come up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
