danny0405 commented on code in PR #10789:
URL: https://github.com/apache/hudi/pull/10789#discussion_r1508493515
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -62,15 +61,14 @@ public class HoodieLogFormatWriter implements
HoodieLogFormat.Writer {
Short replication,
Long sizeThreshold,
String rolloverLogWriteToken,
- LogFileCreationCallback fileCreationHook) {
+ LogFileCreationCallback fileCreationCallback) {
this.fs = fs;
this.logFile = logFile;
this.sizeThreshold = sizeThreshold;
this.bufferSize = bufferSize;
this.replication = replication;
this.rolloverLogWriteToken = rolloverLogWriteToken;
- this.fileCreationHook = fileCreationHook;
- addShutDownHook();
Review Comment:
I guess it is because on HDFS, when a file inputstream is now shutdown
properly, the metadata of that file will be hold for sometime, and if any
thread tries to create a file with the same name, the HDFS reports an lease
occupied error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
