bvaradar commented on code in PR #10789:
URL: https://github.com/apache/hudi/pull/10789#discussion_r1513977038
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -62,15 +61,14 @@ public class HoodieLogFormatWriter implements
HoodieLogFormat.Writer {
Short replication,
Long sizeThreshold,
String rolloverLogWriteToken,
- LogFileCreationCallback fileCreationHook) {
+ LogFileCreationCallback fileCreationCallback) {
Review Comment:
Looking at other places like HoodieWriteHandle#createLogWriter, we are
passing the LogFormatWriter to the caller. So, it does not look like we can get
away by try-with-resource refactoring alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
