danny0405 commented on code in PR #10789:
URL: https://github.com/apache/hudi/pull/10789#discussion_r1508495212
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -62,15 +61,14 @@ public class HoodieLogFormatWriter implements
HoodieLogFormat.Writer {
Short replication,
Long sizeThreshold,
String rolloverLogWriteToken,
- LogFileCreationCallback fileCreationHook) {
+ LogFileCreationCallback fileCreationCallback) {
Review Comment:
The writer is hold and maintained by the outer write handle, the write
handle has its own lifecycle management, I think we should also fix that. But
generally the write handle does not really implement `Closable`, we may need to
enhance it later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
