bvaradar commented on code in PR #10915:
URL: https://github.com/apache/hudi/pull/10915#discussion_r1538107857
##########
hudi-common/src/main/java/org/apache/hudi/common/util/CompactionUtils.java:
##########
@@ -285,8 +285,7 @@ public static List<HoodieInstant>
getPendingCompactionInstantTimes(HoodieTableMe
*/
public static Option<Pair<HoodieTimeline, HoodieInstant>>
getDeltaCommitsSinceLatestCompaction(
HoodieActiveTimeline activeTimeline) {
- Option<HoodieInstant> lastCompaction = activeTimeline.getCommitTimeline()
- .filterCompletedInstants().lastInstant();
+ Option<HoodieInstant> lastCompaction =
activeTimeline.filterCompletedCommitInstants().lastInstant();
Review Comment:
@nsivabalan : Can you rename getCommitTimeline() to
getCommitAndReplaceTimeline() and then add an API getCommitOnlyTimeline().
The current naming of these APIs are very problematic and can easily cause
bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
