danny0405 commented on code in PR #10915:
URL: https://github.com/apache/hudi/pull/10915#discussion_r1538463640
##########
hudi-common/src/main/java/org/apache/hudi/common/util/CompactionUtils.java:
##########
@@ -285,8 +285,7 @@ public static List<HoodieInstant>
getPendingCompactionInstantTimes(HoodieTableMe
*/
public static Option<Pair<HoodieTimeline, HoodieInstant>>
getDeltaCommitsSinceLatestCompaction(
HoodieActiveTimeline activeTimeline) {
- Option<HoodieInstant> lastCompaction = activeTimeline.getCommitTimeline()
- .filterCompletedInstants().lastInstant();
+ Option<HoodieInstant> lastCompaction =
activeTimeline.filterCompletedCommitInstants().lastInstant();
Review Comment:
And we better not reuse the action name for replace commit and compaction
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
