yanghua commented on a change in pull request #1871:
URL: https://github.com/apache/hudi/pull/1871#discussion_r467827467
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java
##########
@@ -237,11 +229,12 @@ public static void
createPendingCleanFiles(HoodieTableMetaClient metaClient, Str
public static void createCorruptedPendingCleanFiles(HoodieTableMetaClient
metaClient, String commitTime) {
Arrays.asList(HoodieTimeline.makeRequestedCleanerFileName(commitTime),
- HoodieTimeline.makeInflightCleanerFileName(commitTime)).forEach(f -> {
+ HoodieTimeline.makeInflightCleanerFileName(commitTime))
+ .forEach(f -> {
Review comment:
Why do we need to break the `forEach`?
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java
##########
@@ -237,11 +229,12 @@ public static void
createPendingCleanFiles(HoodieTableMetaClient metaClient, Str
public static void createCorruptedPendingCleanFiles(HoodieTableMetaClient
metaClient, String commitTime) {
Arrays.asList(HoodieTimeline.makeRequestedCleanerFileName(commitTime),
- HoodieTimeline.makeInflightCleanerFileName(commitTime)).forEach(f -> {
+ HoodieTimeline.makeInflightCleanerFileName(commitTime))
+ .forEach(f -> {
FSDataOutputStream os = null;
try {
Path commitFile = new Path(
- metaClient.getBasePath() + "/" +
HoodieTableMetaClient.METAFOLDER_NAME + "/" + f);
+ metaClient.getBasePath() + "/" +
HoodieTableMetaClient.METAFOLDER_NAME + "/" + f);
Review comment:
Can we use `Paths.get()` to reduce link path parts via `/`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
