danny0405 commented on code in PR #11071:
URL: https://github.com/apache/hudi/pull/11071#discussion_r1581997478
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -198,7 +198,7 @@ private void inlineCompaction(HoodieTable table,
Option<Map<String, String>> ext
* @return Collection of Write Status
*/
protected HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime,
boolean shouldComplete) {
- HoodieTable<?, I, ?, T> table = createTable(config,
context.getHadoopConf().get());
+ HoodieTable<?, I, ?, T> table = createTable(config, (Configuration)
context.getStorageConf().unwrap());
Review Comment:
We can add a interface like `#unwrapAs(Class<T> clazz)` to unwrap the class
as specific type to eliminate the type cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
