danny0405 commented on code in PR #11071:
URL: https://github.com/apache/hudi/pull/11071#discussion_r1581998251
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java:
##########
@@ -67,8 +67,8 @@ public static StorageConfiguration<Configuration>
getStorageConf(Configuration c
return getStorageConf(conf, false);
}
- public static StorageConfiguration<Configuration>
getStorageConf(Configuration conf, boolean copy) {
- return new HadoopStorageConfiguration(conf, copy);
+ public static StorageConfiguration<Configuration>
getStorageConfWithCopy(Configuration conf) {
+ return getStorageConf(conf, true);
Review Comment:
Should we always copy the conf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
