yihua commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1593272677
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java:
##########
@@ -313,7 +313,7 @@ public static Option<HoodieCommitMetadata>
getCommitMetadataForLatestInstant(Hoo
* @return a new {@link HoodieTableMetaClient} instance.
*/
public static HoodieTableMetaClient createMetaClient(JavaSparkContext jsc,
String basePath) {
- return HoodieTestUtils.createMetaClient(jsc.hadoopConfiguration(),
basePath);
+ return
HoodieTestUtils.createMetaClient(HoodieStorageUtils.getStorageConf(jsc.hadoopConfiguration()),
basePath);
Review Comment:
Still keep a test util `HoodieTestUtils.createMetaClient` that takes Hadoop
configuration? Or use `HoodieClientTestUtils#createMetaClient(JavaSparkContext
jsc, String basePath)`?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java:
##########
@@ -322,7 +322,7 @@ public static HoodieTableMetaClient
createMetaClient(JavaSparkContext jsc, Strin
* @return a new {@link HoodieTableMetaClient} instance.
*/
public static HoodieTableMetaClient createMetaClient(SparkSession spark,
String basePath) {
- return
HoodieTestUtils.createMetaClient(spark.sessionState().newHadoopConf(),
basePath);
+ return
HoodieTestUtils.createMetaClient(HoodieStorageUtils.getStorageConf(spark.sessionState().newHadoopConf()),
basePath);
Review Comment:
Use `HoodieTestUtils#createMetaClient(SparkSession spark, String basePath)`?
##########
hudi-client/hudi-java-client/pom.xml:
##########
@@ -42,6 +42,11 @@
<artifactId>hudi-client-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hudi</groupId>
+ <artifactId>hudi-hadoop-common</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Move this above `hudi-client-common`. Also, I think `hudi-client-common`
pulls in `hudi-hadoop-common`? Similar for other POMs.
##########
hudi-client/hudi-client-common/pom.xml:
##########
@@ -43,6 +43,16 @@
<artifactId>hudi-common</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hudi</groupId>
+ <artifactId>hudi-io</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Is this needed, given `hudi-common` module pulls in `hudi-io` dependency
transitively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
