yihua commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1593527111
##########
hudi-common/src/main/java/org/apache/hudi/storage/HoodieStorageUtils.java:
##########
@@ -34,22 +32,35 @@ public static HoodieStorage
getStorage(StorageConfiguration<?> conf) {
}
public static HoodieStorage getStorage(FileSystem fs) {
- return new HoodieHadoopStorage(fs);
+ return (HoodieStorage)
ReflectionUtils.loadClass("org.apache.hudi.storage.hadoop.HoodieHadoopStorage",
new Class<?>[] {FileSystem.class}, fs);
Review Comment:
Similar here on the class name and reflection utils to construct
`HoodieStorage` using reflection.
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java:
##########
@@ -198,24 +199,25 @@ public static HoodieTableMetaClient init(String basePath,
HoodieTableType tableT
}
/**
- * @param storageConf storage configuration.
+ * @param conf storage configuration.
* @param basePath base path of the Hudi table.
* @return a new {@link HoodieTableMetaClient} instance.
*/
- public static HoodieTableMetaClient createMetaClient(StorageConfiguration<?>
storageConf,
+ public static HoodieTableMetaClient createMetaClient(Configuration conf,
Review Comment:
Did you flip the order of these two?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
