yihua commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1593538784
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -202,6 +202,11 @@ public void addPropsFromStream(BufferedReader reader,
StoragePath cfgFilePath) t
}
}
+ @Override
+ public TypedProperties getGlobalProperties() {
Review Comment:
Move the logic of `getGlobalProps()` directly into this new method?
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java:
##########
@@ -211,10 +188,12 @@ public static FSDataInputStream
getFSDataInputStream(FileSystem fs,
return new BoundedFsDataInputStream(fs, convertToHadoopPath(filePath),
fsDataInputStream);
}
+ /*
Review Comment:
uncomment this after fixing `openSeekable`?
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java:
##########
@@ -109,25 +105,6 @@ public static FileSystem getFs(String pathStr,
Configuration conf, boolean local
return getFs(pathStr, conf);
}
- public static HoodieStorage getStorageWithWrapperFS(StoragePath path,
Review Comment:
Is this moved to somewhere else?
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/HoodieFileSliceTestUtils.java:
##########
@@ -267,7 +273,8 @@ public static HoodieBaseFile createBaseFile(
0.1,
true);
- try (HoodieAvroParquetWriter writer = new HoodieAvroParquetWriter(
+ try (HoodieAvroFileWriter writer = (HoodieAvroFileWriter)
ReflectionUtils.loadClass("org.apache.hudi.io.storage.HoodieAvroParquetWriter",
Review Comment:
Make sure you revisit all such reflection calls based on my previous
comments.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HoodieHadoopUtils.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.hadoop.fs;
+
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.hadoop.conf.Configuration;
+
+public class HoodieHadoopUtils {
+
+ public static Configuration registerFileSystem(StoragePath file,
Configuration conf) {
Review Comment:
Should this be in `HadoopFSUtils`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
