jonvex commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1594367946
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java:
##########
@@ -109,25 +105,6 @@ public static FileSystem getFs(String pathStr,
Configuration conf, boolean local
return getFs(pathStr, conf);
}
- public static HoodieStorage getStorageWithWrapperFS(StoragePath path,
Review Comment:
Yeah, since we need to use reflection, I moved it into a new constructor for
HoodieHadoopStorage:
```
public HoodieHadoopStorage(StoragePath path,
StorageConfiguration<?> conf,
boolean enableRetry,
long maxRetryIntervalMs,
int maxRetryNumbers,
long initialRetryIntervalMs,
String retryExceptions,
ConsistencyGuard consistencyGuard) {
FileSystem fileSystem = getFs(path,
conf.unwrapCopyAs(Configuration.class));
if (enableRetry) {
fileSystem = new HoodieRetryWrapperFileSystem(fileSystem,
maxRetryIntervalMs, maxRetryNumbers, initialRetryIntervalMs,
retryExceptions);
}
checkArgument(!(fileSystem instanceof HoodieWrapperFileSystem),
"File System not expected to be that of HoodieWrapperFileSystem");
this.fs = new HoodieWrapperFileSystem(fileSystem, consistencyGuard);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
