jonvex commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1594285849
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java:
##########
@@ -313,7 +313,7 @@ public static Option<HoodieCommitMetadata>
getCommitMetadataForLatestInstant(Hoo
* @return a new {@link HoodieTableMetaClient} instance.
*/
public static HoodieTableMetaClient createMetaClient(JavaSparkContext jsc,
String basePath) {
- return HoodieTestUtils.createMetaClient(jsc.hadoopConfiguration(),
basePath);
+ return
HoodieTestUtils.createMetaClient(HoodieStorageUtils.getStorageConf(jsc.hadoopConfiguration()),
basePath);
Review Comment:
Meta client is is hudi-common so it will take in storage conf.
HoodieTestUtils is also in hudi-common. I don't see what the problem is with my
change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
