danny0405 commented on code in PR #11077:
URL: https://github.com/apache/hudi/pull/11077#discussion_r1596139985
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -91,7 +91,7 @@ public class HoodieMergedLogRecordScanner extends
AbstractHoodieLogRecordReader
private long totalTimeTakenToReadAndMergeBlocks;
@SuppressWarnings("unchecked")
- private HoodieMergedLogRecordScanner(HoodieStorage storage, String basePath,
List<String> logFilePaths, Schema readerSchema,
+ HoodieMergedLogRecordScanner(HoodieStorage storage, String basePath,
List<String> logFilePaths, Schema readerSchema,
String latestInstantTime, Long
maxMemorySizeInBytes,
Review Comment:
Fix the indentation and make the constructor scope as protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
