danny0405 commented on code in PR #11077:
URL: https://github.com/apache/hudi/pull/11077#discussion_r1601315621
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataLogRecordReader.java:
##########
@@ -150,9 +151,9 @@ private static Predicate<String>
createPrefixMatchingPredicate(List<String> keyP
* Builder used to build {@code HoodieMetadataMergedLogRecordScanner}.
*/
public static class Builder {
- private final HoodieMergedLogRecordScanner.Builder scannerBuilder =
- new HoodieMergedLogRecordScanner.Builder()
- .withKeyFiledOverride(HoodieMetadataPayload.KEY_FIELD_NAME)
+ private final HoodieMetadataMergedLogRecordScanner.Builder scannerBuilder =
+ new HoodieMetadataMergedLogRecordScanner.Builder()
Review Comment:
Do we need the scanner for all kinds of metadata index types? The full outer
join may bring in perforamce regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
