KnightChess commented on code in PR #11631:
URL: https://github.com/apache/hudi/pull/11631#discussion_r1679119096
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -255,9 +254,6 @@ public static <T extends SpecificRecordBase> T
convertCommitMetadata(HoodieCommi
}
hoodieCommitMetadata.getPartitionToWriteStats().remove(null);
org.apache.hudi.avro.model.HoodieCommitMetadata avroMetaData =
JsonUtils.getObjectMapper().convertValue(hoodieCommitMetadata,
org.apache.hudi.avro.model.HoodieCommitMetadata.class);
- if (hoodieCommitMetadata.getCompacted()) {
- avroMetaData.setOperationType(WriteOperationType.COMPACT.name());
- }
Review Comment:
@danny0405 no, for example
- logcompat will product `001.logcompact.requested, 001.logcompact.inflight,
001.deltacommit`, action is `deltacommit` and it's `writeOprationType` will be
overwrite from `logcompact` to `compact`.
- compat will product `001.compact.requested, 001.compact.inflight,
001.commit`, action is `commit` and it's `writeOprationType` will be overwrite
from `compact` to `compact`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
