KnightChess commented on code in PR #11631:
URL: https://github.com/apache/hudi/pull/11631#discussion_r1679213318
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -255,9 +254,6 @@ public static <T extends SpecificRecordBase> T
convertCommitMetadata(HoodieCommi
}
hoodieCommitMetadata.getPartitionToWriteStats().remove(null);
org.apache.hudi.avro.model.HoodieCommitMetadata avroMetaData =
JsonUtils.getObjectMapper().convertValue(hoodieCommitMetadata,
org.apache.hudi.avro.model.HoodieCommitMetadata.class);
- if (hoodieCommitMetadata.getCompacted()) {
- avroMetaData.setOperationType(WriteOperationType.COMPACT.name());
- }
Review Comment:
@danny0405 yeah, because log_compaction is `compacted`, so it's
writeOperatorType will be changed to `compact` from `logcompact` and save this
metadata in deltacommit instance. Now, if user rollback the deltacommit which
is logcompact. In fact, this instance action is treated as `deltacommit`, but
the metadata writeOperatorType is `compact` which save in this instance before,
so the runtime action will be change from deltacommit to compact when rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
