danny0405 commented on code in PR #11631:
URL: https://github.com/apache/hudi/pull/11631#discussion_r1679131565
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -255,9 +254,6 @@ public static <T extends SpecificRecordBase> T
convertCommitMetadata(HoodieCommi
}
hoodieCommitMetadata.getPartitionToWriteStats().remove(null);
org.apache.hudi.avro.model.HoodieCommitMetadata avroMetaData =
JsonUtils.getObjectMapper().convertValue(hoodieCommitMetadata,
org.apache.hudi.avro.model.HoodieCommitMetadata.class);
- if (hoodieCommitMetadata.getCompacted()) {
- avroMetaData.setOperationType(WriteOperationType.COMPACT.name());
- }
Review Comment:
> logcompat will product 001.logcompact.requested, 001.logcompact.inflight,
001.deltacommit, action is deltacommit and it's writeOprationType will be
overwrite from logcompact to compact
This is a bug I think, it seems the original fix is more reasonable, another
question is in
`[ListingBasedRollbackStrategy.java](https://github.com/apache/hudi/pull/11631/files#diff-365332eac63a078cd9009480fb3adc14feb755604a26bb07a19c1b0d9c8c8498)`
line 125, if for log_compaction the "compacted" is set up as true, it looks
like the action will also be overritten to "compaction" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
