codope commented on code in PR #11634:
URL: https://github.com/apache/hudi/pull/11634#discussion_r1743759371
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/metadata/JavaHoodieBackedTableMetadataWriter.java:
##########
@@ -87,7 +87,7 @@ protected void initRegistry() {
}
@Override
- protected void commit(String instantTime, Map<MetadataPartitionType,
HoodieData<HoodieRecord>> partitionRecordsMap) {
+ protected void commit(String instantTime, Map<String,
HoodieData<HoodieRecord>> partitionRecordsMap) {
Review Comment:
The map initially meant to be per index type under the assumption that there
is going to be one MDT partition per index type. However, functional or
secondary index types break this assumption. As we discussed, I will add a
separate abstraction to manage different indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
