codope commented on code in PR #11634:
URL: https://github.com/apache/hudi/pull/11634#discussion_r1743769890
##########
hudi-common/src/main/java/org/apache/hudi/metadata/MetadataPartitionType.java:
##########
@@ -319,6 +331,16 @@ public boolean
isMetadataPartitionAvailable(HoodieTableMetaClient metaClient) {
this.recordType = recordType;
}
+ /**
+ * Get the partition name from the metadata partition type.
+ * NOTE: For certain types of metadata partition, such as functional index
and secondary index,
+ * partition path defined enum is just the prefix to denote the type of
metadata partition.
+ * The actual partition name is contained in the index definition.
+ */
+ public String getPartitionPath(HoodieTableMetaClient metaClient, String
indexName) {
+ return getPartitionPath();
+ }
+
public String getPartitionPath() {
return partitionPath;
}
Review Comment:
It's still being used at some places where we don't have metaclient or
indexName. Technically, this can be removed by making the other method accept
`Option<HoodieTableMetaClient> metaClient, Option<String> indexName` as
arguments, but it will change a lot of places. If you're ok, I can do it in a
separate PR after landing this one (just to keep this PR a bit clean).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
