yihua commented on code in PR #11634:
URL: https://github.com/apache/hudi/pull/11634#discussion_r1744813551
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1396,27 +1395,25 @@ protected void preWrite(String instantTime) {
* records and hence is more suited to bulkInsert for write performance.
*
* @param instantTime - Action instant time for this commit
- * @param partitionType - The MDT partition to which records are to be
committed
+ * @param partitionName - The MDT partition to which records are to be
committed
* @param records - records to be bulk inserted
* @param fileGroupCount - The maximum number of file groups to which the
records will be written.
*/
protected abstract void bulkCommit(
- String instantTime, MetadataPartitionType partitionType,
HoodieData<HoodieRecord> records,
+ String instantTime, String partitionName, HoodieData<HoodieRecord>
records,
Review Comment:
Synced offline that the `partitionName` is going to be different per index
definition within secondary and functional index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
