CTTY commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1797784983
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -125,6 +125,15 @@ object DataSourceReadOptions {
+ HollowCommitHandling.USE_TRANSITION_TIME + "`, will use instant's "
+ "`stateTransitionTime` to perform comparison.")
+ /* TODO: this is a replacement of
HoodieIncrSourceConfig.NUM_INSTANTS_PER_FETCH
+ to make incremental instant limit available in spark incremental
relations
+ Need to link HoodieIncrSourceConfig.NUM_INSTANTS_PER_FETCH to this
correctly and add doc*/
+ val INCREMENTAL_LIMIT: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.streamer.source.hoodieincr.num_instants")
Review Comment:
I think this makes sense, will remove this config and its usages in Hudi
incremental relations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
