CTTY commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1797787473
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelation.scala:
##########
@@ -220,15 +209,12 @@ class IncrementalRelation(val sqlContext: SQLContext,
val sOpts = optParams.filter(p => !p._1.equalsIgnoreCase("path"))
- val startInstantTime =
optParams(DataSourceReadOptions.BEGIN_INSTANTTIME.key)
+ val startInstantTime = queryContext.getStartInstant.get()
val startInstantArchived =
commitTimeline.isBeforeTimelineStarts(startInstantTime)
- val endInstantTime =
optParams.getOrElse(DataSourceReadOptions.END_INSTANTTIME.key(),
lastInstant.getTimestamp)
+ val endInstantTime = queryContext.getEndInstant.get()
Review Comment:
This is a good point, I think it also makes no sense to check if
`endInstantArchived` is true here because
1. end instant cannot come before start instant and
2. We should scan the full table if either start or end instant is archived.
Will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
