CTTY commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1797843194
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java:
##########
@@ -88,6 +97,16 @@ public static String latestCommit(HoodieStorage storage,
String basePath) {
return timeline.lastInstant().get().getTimestamp();
}
+ public static String latestCommitCompletionTime(FileSystem fs, String
basePath) {
+ HoodieTimeline timeline = allCompletedCommitsCompactions(fs, basePath);
+ return timeline.lastInstant().get().getCompletionTime();
+ }
+
+ public static String latestCommitCompletionTime(HoodieStorage storage,
String basePath) {
+ HoodieTimeline timeline = allCompletedCommitsCompactions(storage,
basePath);
+ return timeline.lastInstant().get().getCompletionTime();
+ }
Review Comment:
Yes, I think it makes sense. I'll fix the completion time logic now, and
will file a jira to move them to test utils because this will require changing
a lot of classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
