yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1799923742
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -161,16 +152,14 @@ protected BaseHoodieLogRecordReader(HoodieReaderContext
readerContext,
.setBasePath(readerContext.getTablePath()).build();
// load class from the payload fully qualified class name
HoodieTableConfig tableConfig =
this.hoodieTableMetaClient.getTableConfig();
- this.payloadClassFQN = tableConfig.getPayloadClass();
+ this.payloadClassFQN = tableConfig.getAvroPayloadClass();
Review Comment:
It would be good to pass in the `RecordMergeConfig` instance for all places
using the payload class, and get the payload class name from
`RecordMergeConfig` instance directly now. In the future, it's easy to switch
from using payload to merger API or deprecate the code path.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordReader.java:
##########
@@ -75,11 +70,9 @@ private HoodieMergedLogRecordReader(HoodieReaderContext<T>
readerContext,
Option<String> partitionName,
Option<String> keyFieldOverride,
boolean enableOptimizedLogBlocksScan,
- HoodieRecordMerger recordMerger,
Review Comment:
Are these not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
