lokeshj1703 commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1800998677
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieUnmergedFileGroupRecordBuffer.java:
##########
@@ -49,11 +49,11 @@ public class HoodieUnmergedFileGroupRecordBuffer<T> extends
HoodieBaseFileGroupR
public HoodieUnmergedFileGroupRecordBuffer(
HoodieReaderContext<T> readerContext,
HoodieTableMetaClient hoodieTableMetaClient,
+ RecordMergeMode recordMergeMode,
Option<String> partitionNameOverrideOpt,
Option<String[]> partitionPathFieldOpt,
- HoodieRecordMerger recordMerger,
TypedProperties props) {
- super(readerContext, hoodieTableMetaClient, partitionNameOverrideOpt,
partitionPathFieldOpt, recordMerger, props);
+ super(readerContext, hoodieTableMetaClient, recordMergeMode,
partitionNameOverrideOpt, partitionPathFieldOpt, props);
Review Comment:
These changes correspond to change in parameter from `HoodieRecordMerger` to
`RecordMergeMode`. This change was made in `HoodieBaseFileGroupRecordBuffer`
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodiePositionBasedFileGroupRecordBuffer.java:
##########
@@ -68,11 +68,11 @@ public class HoodiePositionBasedFileGroupRecordBuffer<T>
extends HoodieKeyBasedF
public HoodiePositionBasedFileGroupRecordBuffer(HoodieReaderContext<T>
readerContext,
HoodieTableMetaClient
hoodieTableMetaClient,
+ RecordMergeMode
recordMergeMode,
Review Comment:
These changes correspond to change in parameter from `HoodieRecordMerger` to
`RecordMergeMode`. This change was made in `HoodieBaseFileGroupRecordBuffer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
