jonvex commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1803265297
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -90,6 +94,7 @@ public class HoodieStorageConfig extends HoodieConfig {
public static final ConfigProperty<String> LOGFILE_DATA_BLOCK_FORMAT =
ConfigProperty
.key("hoodie.logfile.data.block.format")
.noDefaultValue()
+ .withValidValues(AVRO_DATA_BLOCK.getId().toUpperCase(),
HFILE_DATA_BLOCK.getId().toUpperCase(),
PARQUET_DATA_BLOCK.getId().toUpperCase())
Review Comment:
Yes, but also made other changes to auto capitalize those config values when
set. So should not impact anyone who sets the config with lowercase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
