yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1809705588
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -261,9 +270,19 @@ public static class Config implements Serializable {
+ " to break ties between records with same key in input data.
Default: 'ts' holding unix timestamp of record")
public String sourceOrderingField = "ts";
- @Parameter(names = {"--payload-class"}, description = "subclass of
HoodieRecordPayload, that works off "
- + "a GenericRecord. Implement your own, if you want to do something
other than overwriting existing value")
- public String payloadClassName =
OverwriteWithLatestAvroPayload.class.getName();
+ @Parameter(names = {"--payload-class"}, description = "Deprecated. Use
--merge-mode for overwite or event time merging."
+ + " Subclass of HoodieRecordPayload, that works off a GenericRecord.
Implement your own, if you want to do something "
+ + "other than overwriting existing value")
+ public String payloadClassName = null;
+
+ @Parameter(names = {"--merge-mode", "--record-merge-mode"}, description =
"mode to merge records with")
+ public RecordMergeMode recordMergeMode = null;
+
+ @Parameter(names = {"--merger-strategy", "--record-merger-strategy"},
description = "only set this if you are using custom merge mode")
Review Comment:
For new configs or cmd arguments added, let's make the naming consistent.
```suggestion
@Parameter(names = {"--merger-strategy-id",
"--record-merge-strategy-id"}, description = "only set this if you are using
custom merge mode")
```
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -261,9 +270,19 @@ public static class Config implements Serializable {
+ " to break ties between records with same key in input data.
Default: 'ts' holding unix timestamp of record")
public String sourceOrderingField = "ts";
- @Parameter(names = {"--payload-class"}, description = "subclass of
HoodieRecordPayload, that works off "
- + "a GenericRecord. Implement your own, if you want to do something
other than overwriting existing value")
- public String payloadClassName =
OverwriteWithLatestAvroPayload.class.getName();
+ @Parameter(names = {"--payload-class"}, description = "Deprecated. Use
--merge-mode for overwite or event time merging."
+ + " Subclass of HoodieRecordPayload, that works off a GenericRecord.
Implement your own, if you want to do something "
+ + "other than overwriting existing value")
+ public String payloadClassName = null;
+
+ @Parameter(names = {"--merge-mode", "--record-merge-mode"}, description =
"mode to merge records with")
+ public RecordMergeMode recordMergeMode = null;
+
+ @Parameter(names = {"--merger-strategy", "--record-merger-strategy"},
description = "only set this if you are using custom merge mode")
+ public String recordMergerStrategy = null;
+
+ @Parameter(names = {"--merger-impls", "--record-merger-impls"},
description = "Comma separated list of classes that implement the record merger
strategy")
Review Comment:
Also use the name I suggested before.
```suggestion
@Parameter(names = {"--merge-impls", "--record-merge-impls"},
description = "Comma separated list of classes that implement the record merger
strategy")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
